Skip to content

Make use_list param configurable in Connector #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
artembo opened this issue Aug 24, 2020 · 0 comments
Closed

Make use_list param configurable in Connector #166

artembo opened this issue Aug 24, 2020 · 0 comments
Labels
feature A new functionality

Comments

@artembo
Copy link
Contributor

artembo commented Aug 24, 2020

By default use_list parameter tells msgpack to unpack array to
Python's list which is not hashable and can not be used as a dict keys
and sets elements. Django expects the response rows to be tuples
because it will be used in python set() [1]

Need to make it configurable to let the user choose which type of rows
can be fetched from the database response.

[1] https://github.com/django/django/blob/stable/3.0.x/django/contrib/auth/management/__init__.py#L72

@artembo artembo added the feature A new functionality label Aug 24, 2020
@artembo artembo linked a pull request Aug 24, 2020 that will close this issue
@artembo artembo mentioned this issue Aug 26, 2020
artembo added a commit that referenced this issue Oct 18, 2020
It is set up to be converted to lists by default. Django expects row
type to be tuple. Also tuples tend to perform better than lists and
it is good if it can be configurable.

Closes #166
artembo added a commit that referenced this issue Oct 26, 2020
It is set up to be converted to lists by default. Django expects row
type to be tuple. Also tuples tend to perform better than lists and
it is good if it can be configurable.

Closes #166
artembo added a commit that referenced this issue Oct 28, 2020
It is set up to be converted to lists by default. Django expects row
type to be tuple. Also tuples tend to perform better than lists and
it is good if it can be configurable.

Closes #166
artembo added a commit that referenced this issue Oct 30, 2020
It is set up to be converted to lists by default. Django expects row
type to be tuple. Also tuples tend to perform better than lists and
it is good if it can be configurable.

Closes #166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant