Skip to content

php8 compat #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

php8 compat #170

wants to merge 1 commit into from

Conversation

stefansaraev
Copy link
Contributor

^ as title says

@Totktonada
Copy link
Member

Thanks! I'll glance when the time will permit.

At least I would add the new PHP version into CI.

@stefansaraev
Copy link
Contributor Author

umh, while I am sure this worked fine with php8.0 and older tarantool 2.x, unfortunately it is not enough for php8.1 and tarantool 2.10. when doing select() on some spaces, we get "ER_INVALID_MSGPACK: Invalid MsgPack - packet body", and I dont have the knowledge to investigate that one.

it seems tarantool-php/client is the recommended way now, and we'll have to move.

I'll just close this PR and let someone with more knowledge than me fix tarantool-php when the time comes.

apologies for the noise this PR have created.

@Totktonada
Copy link
Member

If you can move to tarantool-php/client, that's the preferred option.

It is my fault. Something always sift out of hands.

@Totktonada Totktonada mentioned this pull request Apr 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefansaraev @Totktonada