Skip to content

Support isWrapperFor() and unwrap() methods #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

nicktorwald
Copy link

Add missed implementation of Wrapper interface for SQLDatabaseMetadata,
SQLResultSet, and SQL ResultSetMetaData classes.

Closes: #73

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 64.472% when pulling a2858eb on nicktorwald/gh-73-wrapper-support into 06755d5 on master.

@nicktorwald nicktorwald requested a review from Totktonada April 10, 2019 06:59
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one comment.

Add missed implementation of Wrapper interface for SQLDatabaseMetadata,
SQLResultSet, and SQL ResultSetMetaData classes.

Closes: #73
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-73-wrapper-support branch from a2858eb to ed13dff Compare April 16, 2019 19:47
@nicktorwald nicktorwald merged commit d6716b1 into master Apr 17, 2019
@nicktorwald
Copy link
Author

nicktorwald commented Apr 17, 2019

reverted and cherry-picked in 8b72cf2

@nicktorwald nicktorwald deleted the nicktorwald/gh-73-wrapper-support branch April 17, 2019 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jdbc: Support isWrapperFor() and unwrap() methods
3 participants