Skip to content

Add support for result set type and concurrency #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nicktorwald
Copy link

@nicktorwald nicktorwald commented Apr 5, 2019

Provide support for FORWARD_ONLY and INSENSITIVE scroll types. Now
statements as well as theirs resultSets can be built using a forward
only iterator or full implemented insensitive iterator. To achieve this
iteration logic was extracted into two separate classes to support two
scroll types respectively. This is a cross-cutting support through
SQLMetadata, SQLConnection, SQL(Prepared)Statement, SQLResultSet.

Add support for READ_ONLY concurrency level for a result set.

Extend SQLStates constants in scope of cursors and query execution.
0100E and 02000 for query results; 24000 for cursor iteration support.

Add missed implementation of a closing for SQLStatement and
SQLResultSet.

Deprecate JDBCBridge. This redundant class should be removed completely
in scope of another task. Mapping of field labels was moved to
SQLResultSet.

Closes: #85, #86
Affects: #119, #108

@coveralls
Copy link

coveralls commented Apr 5, 2019

Coverage Status

Coverage increased (+4.3%) to 69.334% when pulling 122be31 on nicktorwald/gh-85-resultSet-type into af74a8c on master.

@nicktorwald nicktorwald requested a review from Totktonada April 5, 2019 17:04
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-85-resultSet-type branch from 30427b3 to bf8eb95 Compare April 6, 2019 20:47
@nicktorwald nicktorwald changed the title Add support for JDBC result set type Add support for result set type and concurrency Apr 6, 2019
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-85-resultSet-type branch from bf8eb95 to 3f3596a Compare April 7, 2019 10:50
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adorable :)

@nicktorwald nicktorwald force-pushed the nicktorwald/gh-85-resultSet-type branch 2 times, most recently from 6dd6908 to 62ee0ee Compare April 16, 2019 19:32
Provide support for FORWARD_ONLY and INSENSITIVE scroll types. Now
statements as well as theirs resultSets can be built using a forward
only iterator or full implemented insensitive iterator. To achieve this
iteration logic was extracted into two separate classes to support two
scroll types respectively. This is a cross-cutting support through
SQLMetadata, SQLConnection, SQL(Prepared)Statement, SQLResultSet.

Add support for READ_ONLY concurrency level for a result set.

Extend SQLStates constants in scope of cursors and query execution.
0100E and 02000 for query results; 24000 for cursor iteration support.

Add missed implementation of a closing for SQLStatement and
SQLResultSet.

Deprecate JDBCBridge. This redundant class should be removed completely
in scope of another task. Mapping of field labels was moved to
SQLResultSet.

Closes: #85, #86
Affects: #119, #108
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-85-resultSet-type branch from 62ee0ee to 122be31 Compare April 17, 2019 21:10
@nicktorwald
Copy link
Author

Pushed in acb17e4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jdbc: Support resultSetType parameter in Connection methods
3 participants