Extract read/write operations into util classes #135
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 12, 2019
nicktorwald
approved these changes
Mar 13, 2019
Totktonada
changed the title
|
Hm. I wrongly pushed ${this_repo}:master to ponomarevDmitri:master, the PR automatically becomes closed and so I cannot try to push rebased changes to it again (permission denied). Sorry for this confusion. I'll merge the PR manually. |
|
Made some renaming and pushed as 9b3f91f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create TarantoolBinaryPacket class that describes tarantool binary
protocol message.
Move logic of sending bytes, receiving binary messages (packets),
creating packet and connecting to a tarantool instance from
TarantoolBase and TarantoolClientImpl to BinaryProtoUtils class.