bugfix: verify presence of the given version #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafin
reviewed
Feb 27, 2024
The action installs tarantool using the following command.
```sh
sudo apt-get install -y tarantool=${version}* tarantool-dev=${version}*
```
If there is no exactly matching version, `apt-get` installs an available
one.
For example, Ubuntu Jammy (22.04) has tarantool-2.6.0 in distro's
repository and an attempt to install a non-existing tarantool version
gives tarantool-2.6.0.
This behavior makes things especially confusing when the `ubuntu-latest`
[runner label][1] changes its meaning. For example, when `ubuntu-latest`
meant Ubuntu Focal (20.04) the action successfully installs
tarantool-1.10.6. Later, `ubuntu-latest` was updated to Ubuntu Jammy
(22.04) and the same action invocation installs 2.6.0, because there is
no 1.10.6 package for Ubuntu Jammy.
After this commit such an update doesn't lead to installation of an
unexpected tarantool version: it leads to an explicit error.
Part of #36
[1]: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#choosing-github-hosted-runners
Before this commit the action attempts to run `tarantool --version` even after an error during its installation. It shows 'unable to locate executable file' error after the root error that makes the report less clear for a user. Part of #36
Totktonada
force-pushed
the
Totktonada/gh-36-verify-tarantool-version
branch
from
0731639 to
e46eb36
Compare
grafin
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The action installs tarantool using the following command.
If there is no exactly matching version,
apt-getinstalls an available one.For example, Ubuntu Jammy (22.04) has tarantool-2.6.0 in distro's repository and an attempt to install a non-existing tarantool version gives tarantool-2.6.0.
This behavior makes things especially confusing when the
ubuntu-latestrunner label changes its meaning. For example, whenubuntu-latestmeant Ubuntu Focal (20.04) the action successfully installs tarantool-1.10.6. Later,ubuntu-latestwas updated to Ubuntu Jammy (22.04) and the same action invocation installs 2.6.0, because there is no 1.10.6 package for Ubuntu Jammy.After this patchset such an update doesn't lead to installation of an unexpected tarantool version: it leads to an explicit error.
The patchset also eliminates the 'unable to locate executable file' error after failed attempt to install tarantool. It makes the error diagnostics more clear.
Part of #36