Skip to content

Make Tarantool spaces synchronous again #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ligurio opened this issue Oct 15, 2020 · 0 comments
Closed

Make Tarantool spaces synchronous again #51

ligurio opened this issue Oct 15, 2020 · 0 comments
Assignees
@ligurio

Comments

@ligurio
Copy link
Member

ligurio commented Oct 15, 2020 •
edited
Loading

As described in documentation synchronous replication can be enabled per-space using the is_sync option. This option was missed after switching from Lua to SQL in tests.

(was lost in 3214905)

It is not possible to change is_sync using SET SESSION in SQL:

unix/:/var/run/tarantool/jepsen.control>  box.space._session_settings:select()
---
- - ['error_marshaling_enabled', false]
  - ['sql_default_engine', 'memtx']
  - ['sql_defer_foreign_keys', false]
  - ['sql_full_column_names', false]
  - ['sql_full_metadata', false]
  - ['sql_parser_debug', false]
  - ['sql_recursive_triggers', true]
  - ['sql_reverse_unordered_selects', false]
  - ['sql_select_debug', false]
  - ['sql_vdbe_debug', false]
...

But it is possible to create Lua function in SQL and use box.space.j:alter{is_sync = true} in it.
@ligurio ligurio self-assigned this Oct 16, 2020
ligurio added a commit that referenced this issue Oct 16, 2020
@ligurio
Make spaces used in tests synchronous
4d3483d 
Synchronous replication should be enabled per-space using the `is_sync` option.
This option has been accidentally lost in a commit "Rewrite client in a
register workload" 3214905

Closes #51
ligurio added a commit that referenced this issue Oct 16, 2020
@ligurio
Make spaces used in tests synchronous
6861c74 
Synchronous replication should be enabled per-space using the `is_sync` option.
This option has been accidentally lost in a commit "Rewrite client in a
register workload" 3214905

Closes #51
ligurio added a commit that referenced this issue Nov 27, 2021
@ligurio
Make spaces synchronous in a bank tests
16fe1ed 
Accidentally option for enabling synchronous mode for spaces in bank
tests was not used. It means that with Tarantool cluster we tested
asynchronous replication that has lower consistency guarantess that
synchronous (eventual consistency). This patch enables is_sync for all
spaces used in bank tests.

For other tests option "is_sync" was enabled in commit "Make spaces used
in tests synchronous" (dfb4d45).

Follows up #51
@ligurio ligurio mentioned this issue Nov 27, 2021
Merged
ligurio added a commit that referenced this issue Nov 30, 2021
@ligurio
Make spaces synchronous in a bank tests
bbe6e63 
Accidentally option for enabling synchronous mode for spaces in bank
tests was not used. It means that with Tarantool cluster we tested
asynchronous replication that has lower consistency guarantess that
synchronous (eventual consistency). This patch enables is_sync for all
spaces used in bank tests.

For other tests option "is_sync" was enabled in commit "Make spaces used
in tests synchronous" (dfb4d45).

Follows up #51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ligurio ligurio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ligurio