Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

add simple tests for @skip and @include directives #76

Merged
merged 2 commits into from
Mar 15, 2018
Merged

Conversation

SudoBobo
Copy link
Contributor

Closes #45

@SudoBobo SudoBobo requested a review from Totktonada March 13, 2018 18:12
@SudoBobo SudoBobo self-assigned this Mar 13, 2018
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add Fixes #45 to the commit message.

order_collection(description: $description) {
order_id
description
user_connection @skip(if: $is, first_name: $first_name) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe name it $skip or use not $is (we can?)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can. It will make the test a little bit more clear

@SudoBobo SudoBobo changed the title add simple tests for @skip and @include directives add simple tests for @skip and @include directives, Fixes #45 Mar 14, 2018
@SudoBobo SudoBobo changed the title add simple tests for @skip and @include directives, Fixes #45 add simple tests for @skip and @include directives Mar 14, 2018
@SudoBobo SudoBobo merged commit 4ded4d7 into master Mar 15, 2018
@SudoBobo SudoBobo deleted the sb/directives branch May 26, 2018 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants