This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Fix flaky fails with hang tests #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that frontend wait infinitely for a storage server, which have not been initialized due to the error like the following. ``` Start failed: builtin/box/console.lua:560: failed to create server localhost:57988: Address already in use ``` The problem is described in [1] (see comment itself, the issue is about the another problem). The gist of the fix is using unix sockets for admin console of non-default servers (storages), it is why test-run update is needed. The option 'use_unix_sockets' affects only console (admin) socket and does nothing with binary (listen) port of a storage. It is critical in the benchmarking test suite. [1]: tarantool/test-run#115 (comment)
Totktonada
force-pushed
the
fix-flaky-tests
branch
from
2bbbb69 to
77891e7
Compare
Totktonada
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that frontend wait infinitely for a storage server, which
have not been initialized due to the error like the following.
The problem is described in 1 (see comment itself, the issue is about
the another problem).
The gist of the fix is using unix sockets for admin console of
non-default servers (storages), it is why test-run update is needed. The
option 'use_unix_sockets' affects only console (admin) socket and does
nothing with binary (listen) port of a storage. It is critical in the
benchmarking test suite.