Create RPM spec #152

Totktonada · 2018-05-21T00:14:38Z

Closes #97.

SudoBobo · 2018-06-13T14:33:05Z

rpm/tarantool-graphql.spec

+make test
+
+%install
+mkdir -p %{br_module_dir}


Shouldn't we delete previous installation before installing the new one?

I guess preparing of sandboxed build / install directories (it is not ones where a package will be installed finally, but they has the same directory structure) is rpmbuild task.

SudoBobo · 2018-06-13T15:08:37Z

rpm/tarantool-graphql.spec

+Requires: tarantool >= 1.9.0.0
+#Requires: tarantool-avro-schema >= 2.0.71, tarantool-avro-schema < 3.0.0.0
+#Requires: lulpeg
+


Don't we need shard, http, lrexlib in Requires? We need them not only for tests

They are optional. Are there recommended packages or like so? If so, we can add they to recommended. Otherwise, I think, we shouldn’t.

We can use Suggests: These dependencies will not be installed during package installation, instead they would be shown to user as an option.

Totktonada · 2018-07-18T02:59:49Z

rpm/tarantool-graphql.spec

+# Dependencies for a user
+Requires: tarantool >= 1.9.0.0
+Requires: tarantool-avro-schema >= 2.0.71
+BuildRequires: tarantool-shard >= 2.1.0


Should not be mandatory dependecy as well as should not be listed as BuildRequires twice.

Sure, my mistake.

Totktonada · 2018-07-18T03:01:07Z

test.sh

+cd ..
+cd graphql
+git submodule update --recursive --init
+# todo fix it with RPM packages


Can we switch testing to centos-7?

Travis support only ubuntu and os x. We may run tests in centos-7 in docker.

I think we can deduplicate some code if switch to centos-7, but it is not so. Nevermind.

Totktonada · 2018-07-18T03:02:47Z

rpm/tarantool-graphql.spec

@@ -0,0 +1,57 @@
+Name: tarantool-graphql
+Version: 0.0.0


Version: 0.0.0 # placeholder

Would that works correctly?

Fixed that to 0.0.1 and added a comment that tells that packpack sets VERSION during build.

Totktonada · 2018-07-18T03:03:16Z

rpm/prebuild-el-7.sh

+sudo yum -y install tarantool tarantool-devel \
+    msgpuck-devel \
+    pcre2 pcre2-devel
+cd / && sudo tarantoolctl rocks install lulpeg


Now we can use RPM.

Totktonada · 2018-07-27T13:10:47Z

graphql/accessor_general.lua

@@ -3,6 +3,7 @@
 ---
 --- It provides basic logic for such space-like data storages and abstracted
 --- away from details from where tuples are arrived into the application.
+package.cpath = package.cpath .. ";/usr/share/tarantool/pcre2/?.so"


Hey, what is this?

Removed this debugging stuff.

Totktonada · 2018-07-27T13:10:56Z

graphql/core/parse.lua

@@ -1,3 +1,4 @@
+package.path = package.path .. ";/usr/share/tarantool/lulpeg/?.lua"


Totktonada · 2018-07-27T13:29:51Z

rpm/prebuild-el-6.sh

+cd Python-2.7.6
+sudo ./configure --prefix=/usr/local 2>&1 >/dev/null
+sudo make 2>&1 >/dev/null
+sudo make install 2>&1 >/dev/null


Proposed to fix Makefile:

test: lint - virtualenv -p python2.7 ./.env-2.7 - . ./.env-2.7/bin/activate && \ + virtualenv -p python2 ./.env-2 + . ./.env-2/bin/activate && \

Fixed this way.

Totktonada · 2018-07-27T13:30:42Z

tools/ubuntu.trusty.test.sh

+
+#curl -s https://packagecloud.io/install/repositories/tarantool/1_7/script.deb.sh | sudo bash
+#sudo apt-get update > /dev/null
+#sudo apt-get -q -y install tarantool tarantool-dev


What is this?

Totktonada · 2018-07-27T13:32:35Z

tools/ubuntu.trusty.test.sh

+
+sudo apt-get -qq update
+curl http://download.tarantool.org/tarantool/1.9/gpgkey |
+sudo apt-key add -release=`lsb_release -c -s`


sudo apt-key add - # this is part of the previous command (after pipeline); use backslash and indent
release=lsb_release -c -s # this is another command

Sorry, fixed.

Totktonada · 2018-07-27T13:33:01Z

tools/ubuntu.trusty.test.sh

+# append two lines to a list of source repositories
+sudo rm -f /etc/apt/sources.list.d/*tarantool*.list
+echo "deb http://download.tarantool.org/tarantool/1.9/ubuntu/ trusty main" |
+sudo tee /etc/apt/sources.list.d/tarantool_1_9.list


backslash + indent

Also fixed.

Totktonada · 2018-07-27T13:33:05Z

tools/ubuntu.trusty.test.sh

+echo "deb http://download.tarantool.org/tarantool/1.9/ubuntu/ trusty main" |
+sudo tee /etc/apt/sources.list.d/tarantool_1_9.list
+echo "deb-src http://download.tarantool.org/tarantool/1.9/ubuntu/ trusty main" |
+sudo tee -a /etc/apt/sources.list.d/tarantool_1_9.list


backslash + indent

Totktonada · 2018-07-27T13:33:42Z

tools/ubuntu.trusty.test.sh

+echo "deb-src http://download.tarantool.org/tarantool/1.9/ubuntu/ trusty main" |
+sudo tee -a /etc/apt/sources.list.d/tarantool_1_9.list
+
+sudo apt-get update > /dev/null


Why we are hide this output?

I just copy-pasted it from one of the tarantool scripts. But it seems to be more consistent without hiding.

Totktonada · 2018-07-27T13:35:46Z

tools/ubuntu.trusty.test.sh

+
+# append two lines to a list of source repositories
+sudo rm -f /etc/apt/sources.list.d/*tarantool*.list
+echo "deb http://download.tarantool.org/tarantool/1.9/ubuntu/ trusty main" |


Suggested to use ${release} insteaad of trusty.

dependencies, added deploy to travis.

Totktonada · 2018-07-27T13:39:08Z

tools/ubuntu.trusty.test.sh

+sudo apt-get -q -y install tarantool tarantool-dev
+
+cd ..
+git clone https://github.com/rtsisyk/msgpuck


For avro-schema?

For shard. There are msgpuck packages in our 1_7 packagecloud repo, but not in 1_9.

So, why don't fix it?

https://github.com/rtsisyk/msgpuck/blob/master/.travis.yml

Ouch, sorry, now it is here: https://github.com/tarantool/msgpuck/blob/master/.travis.yml

Fixed, added deploy of msgpuck to 1_9, 1_10, 2_0 repos.

Totktonada · 2018-07-27T13:41:50Z

tools/ubuntu.trusty.test.sh

+# maybe we can use tarantool headers?
+sudo apt-get install lua5.1
+sudo apt-get install liblua5.1-0-dev
+wget "http://luarocks.github.io/luarocks/releases/luarocks-2.4.4.tar.gz"


Why don't use https://packages.ubuntu.com/trusty/luarocks ?

No reason. Fixed to package usage.

Totktonada · 2018-07-27T14:08:38Z

rpm/tarantool-graphql.spec

+#Suggests: tarantool-lrexlib-pcre2
+#Suggests: tarantool-shard
+#Suggests: tarantool-http
+#Suggests: tarantool-avro-schema


Avro-schema is is requires.

Please, comment why Suggests are commented.

I'd like to remove it totally.

Why? I’d like this feature. When a package manager has no flags like portage does it is way to inform user about possible feature s/he can miss.

We can have it commented and uncomment when all actual distros will have necessary package manager versions.

We can have it commented and uncomment when all actual distros will have necessary package manager versions.

Well, I'm ok with it. Left it commented, removed avro-schema.

So… point 2 in the first message of the thread:

Please, comment why Suggests are commented.

Put certain tools names and versions to allow easily catch it up in the future.

Added comment and version for shard.

Totktonada · 2018-07-27T14:08:51Z

rpm/tarantool-graphql.spec

+
+# Dependencies for a user
+Requires: tarantool >= 1.9.0.0
+Requires: tarantool-avro-schema >= 2.0.0


Why not explicit 2.0.71?

Totktonada · 2018-07-27T14:12:22Z

.travis.yml

-  - sudo luarocks install ldoc
+env:
+    global:
+      - PRODUCT=tarantool-graphql


It seems to be redundant, is it so?

Well, if not set, PRODUCT is determined by packpack from the name of the .spec file. So yes, it redundant.

Totktonada · 2018-07-27T14:14:05Z

.travis.yml

-    sudo apt-key add -release=`lsb_release -c -s`
+cache:
+    directories:
+      - $HOME/.cache


You don’t place anything into .cache explicitly or implicitly, so why? Or docker stores something here?

I don’t strongly against, but prefer to understand what and why we have.

Packpack uses it.

Thanks for clarification.

Totktonada · 2018-07-30T07:44:46Z

tools/ubuntu.trusty.test.sh

+tarantoolctl rocks install http
+tarantoolctl rocks install shard "${SHARD_VERSION}"
+tarantoolctl rocks install avro-schema "${AVRO_SCHEMA}"
+# lua (with dev headers) is necessary for luacheck


Now, when you are install luarocks from the package manager, there are no need to manually install lua5.1 and liblua5.1-0-dev? The comment seems to be slightly unaccurate: luacheck is pure lua and doesn’t require lua headers.

Yes, there is no need for them. Removed.

Totktonada added the infrastructure label May 21, 2018

Totktonada self-assigned this May 21, 2018

SudoBobo reviewed Jun 13, 2018

View reviewed changes

SudoBobo force-pushed the gh-97-add-rpm-spec branch 5 times, most recently from 363b9ef to 1ed2dba Compare July 11, 2018 13:30

Totktonada commented Jul 18, 2018

View reviewed changes

Create RPM spec

5cea913

SudoBobo force-pushed the gh-97-add-rpm-spec branch 4 times, most recently from b4042b6 to 9c9ff8c Compare July 23, 2018 13:01

Totktonada commented Jul 27, 2018

View reviewed changes

Fixed .spec to use rpms instead of prebuildes

a2e0cae

dependencies, added deploy to travis.

Totktonada commented Jul 27, 2018

View reviewed changes

SudoBobo force-pushed the gh-97-add-rpm-spec branch from d8c4709 to 3c1d583 Compare July 27, 2018 13:48

Totktonada commented Jul 27, 2018

View reviewed changes

SudoBobo changed the title ~~WIP: Create RPM spec~~ Create RPM spec Jul 29, 2018

SudoBobo force-pushed the gh-97-add-rpm-spec branch from fb10803 to c341273 Compare July 29, 2018 23:01

Totktonada commented Jul 30, 2018

View reviewed changes

SudoBobo force-pushed the gh-97-add-rpm-spec branch from c341273 to 365e3c9 Compare July 30, 2018 14:05

Review fixes

10a54e8

SudoBobo force-pushed the gh-97-add-rpm-spec branch from 365e3c9 to 10a54e8 Compare July 30, 2018 14:09

Minor and preferential RPM spec changes

0110584

Totktonada force-pushed the gh-97-add-rpm-spec branch from 0d2aa42 to 0110584 Compare July 31, 2018 22:54

Totktonada merged commit 79f01fc into master Jul 31, 2018

Totktonada deleted the gh-97-add-rpm-spec branch July 31, 2018 23:32

		@@ -1,3 +1,4 @@
		package.path = package.path .. ";/usr/share/tarantool/lulpeg/?.lua"

Create RPM spec #152

Create RPM spec #152

Conversation

Totktonada commented May 21, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SudoBobo Jun 13, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SudoBobo Jul 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SudoBobo Jul 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SudoBobo Jul 29, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SudoBobo Jul 29, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Totktonada commented May 21, 2018 •

edited

Loading

SudoBobo Jun 13, 2018 •

edited

Loading

SudoBobo Jul 19, 2018 •

edited

Loading

SudoBobo Jul 19, 2018 •

edited

Loading

SudoBobo Jul 29, 2018 •

edited

Loading

SudoBobo Jul 29, 2018 •

edited

Loading