Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Add missing numeric avro types and bool #106

Closed
wants to merge 1 commit into from
Closed

Conversation

opomuc
Copy link

@opomuc opomuc commented Apr 4, 2018

Closes #31

@opomuc opomuc requested a review from Totktonada April 4, 2018 11:28
@Totktonada
Copy link
Member

Totktonada commented Apr 4, 2018

Questions to think about:

  1. double field is added to the types module in the tarantool_graphql module.
  2. Float is 64-bt in GraphQL, AFAIR. We need to convert avro-schema double into GraphQL Float. Maybe we need also create Double type that will be full alias of the Float (and can be used instead in any place). Possible problem: use a Double variable for a Float argument and vice versa.
  3. You are use node.kind == 'double', but core/parser.lua does not emit such nodes (it emit float ones).
  4. No tests.

@Totktonada
Copy link
Member

Closed in favor of PR #128. Roman, thanks for the effort!

@Totktonada Totktonada closed this Apr 20, 2018
@Totktonada Totktonada deleted the add-missing-types branch April 20, 2018 14:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants