Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Support for float, double and boolean avro types #31

Closed
Totktonada opened this issue Feb 1, 2018 · 2 comments
Closed

Support for float, double and boolean avro types #31

Totktonada opened this issue Feb 1, 2018 · 2 comments
Assignees
@Totktonada
Labels
enhancement New feature or request prio1
Milestone
0.0.1

Comments

@Totktonada
Copy link
Member

No description provided.

@Totktonada Totktonada added prio3 enhancement New feature or request labels Feb 1, 2018
@Totktonada Totktonada changed the title Support for float and boolean avro types Support for float, double and boolean avro types Apr 3, 2018
opomuc added a commit that referenced this issue Apr 4, 2018
@opomuc
Add missing numeric avro types and bool
36820b8 
Closes #31
@opomuc opomuc mentioned this issue Apr 4, 2018
Closed
opomuc added a commit that referenced this issue Apr 4, 2018
@opomuc
Add missing numeric avro types and bool
dc39e04 
Closes #31
Kasen pushed a commit that referenced this issue Apr 13, 2018
@opomuc @Kasen
Add missing numeric avro types and bool
b46215d 
Closes #31
@Totktonada Totktonada added this to the 0.0.1 milestone Apr 17, 2018
@Totktonada Totktonada added prio1 and removed prio3 labels Apr 17, 2018
@Totktonada Totktonada self-assigned this Apr 20, 2018
@Totktonada
Copy link
Member Author

Don’t add float (and/or double) to arguments, because it will lead to comparing floats by value. Use expressions (#13) instead.

@Totktonada
Copy link
Member Author

Extracted from PR #106:

Float is 64-bt in GraphQL. We need to convert avro-schema double into GraphQL Float. Or we need also create Double type that will be full alias of the Float (and can be used instead in any place). Possible problem: use a Double variable for a Float argument and vice versa.

@Totktonada Totktonada mentioned this issue Apr 20, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Totktonada Totktonada

Labels
enhancement New feature or request prio1
Projects
None yet
Milestone
0.0.1
Development

No branches or pull requests
1 participant
@Totktonada