-
Notifications
You must be signed in to change notification settings - Fork 60
Update vmihailenco/msgpack to v5 #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
First, it is breaking change, therefore it could not be merged before V2. |
|
@FZambia hmm... looks promising. |
Good idea. |
Yeah, this is still a breaking change... But maybe this can help staying with |
We need msgpack.RawMessage support and going to maintain internal fork until this is merged. |
This work is continued in PR #174. |
Breaking change
Now msgpack encoded integers decodes to corresponding Golang integer type.
It's the behaviour of the new version of vmihailenco/msgpack library.
For example:
before: int8 msgpack encoded integer decodes to int64 Golang variable
now: int8 msgpack encoded integer decodes to int8 Golang variable