box: added logic for working with Tarantool schema #446
Conversation
bigbes
force-pushed
the
bigbes/TNTP-3331-box-schema-wrappers
branch
from
5d1b376 to
b869130
Compare
|
Is this PR ready for review? If so, please assign two reviewers from the team (usually one of them is the repository maintainer, but it is not necessary). |
|
The dot is missed. -> |
It looks a bit ugly for me. For example, I don’t understand why the timestamp might be useful to us. I like the co-authored-by label in the commit message instead: But up to you. |
Implemented the `box.Schema()` method that returns a `Schema` object for schema-related operations. Co-authored-by: maksim.konovalov <[email protected]>
bigbes
force-pushed
the
bigbes/TNTP-3331-box-schema-wrappers
branch
from
b869130 to
fc70848
Compare
bigbes
force-pushed
the
bigbes/TNTP-3331-box-schema-wrappers
branch
from
fc70848 to
afcd25f
Compare
* preemptive checking for empty connection * hide constructors for schema and etc * redo (minify) API for box.session.su (simplify it) * added mock tests to check API
bigbes
force-pushed
the
bigbes/TNTP-3331-box-schema-wrappers
branch
from
afcd25f to
fab4d84
Compare
| if conn == nil { | ||
| // Check if the provided Tarantool connection is nil, and if it is, panic with an error | ||
| // message. panic early helps to catch and fix nil pointer issues in the code. | ||
| panic("tarantool connection cannot be nil") | ||
| } |
There was a problem hiding this comment.
I don't see the point. Whether panic happens here or somewhere else on nil dereference, it will happen anyway and it can be easily identified.
| if conn == nil { | |
| // Check if the provided Tarantool connection is nil, and if it is, panic with an error | |
| // message. panic early helps to catch and fix nil pointer issues in the code. | |
| panic("tarantool connection cannot be nil") | |
| } |
| func TestMocked(t *testing.T) { | ||
| t.Run("Box.Info", func(t *testing.T) { |
There was a problem hiding this comment.
Let's just write three different tests. Motivation: everywhere in the connector, separate test cases are used, instead of the subtests.
| func TestMocked(t *testing.T) { | |
| t.Run("Box.Info", func(t *testing.T) { | |
| func TestMocked_BoxInfo(t *testing.T) { |
|
|
||
| func Ptr[T any](val T) *T { | ||
| return &val | ||
| } |
There was a problem hiding this comment.
Please, add a comment for the public function and move it to test_helpers/utils.go .
| @@ -0,0 +1,28 @@ | |||
| package box | |||
There was a problem hiding this comment.
Please, test only the public API.
| package box | |
| package box_test |
| @@ -0,0 +1,65 @@ | |||
| package box | |||
There was a problem hiding this comment.
| package box | |
| package box_test |
| @@ -0,0 +1,210 @@ | |||
| package box | |||
There was a problem hiding this comment.
| package box | |
| package box_test |
| @@ -0,0 +1,39 @@ | |||
| package box | |||
There was a problem hiding this comment.
| package box | |
| package box_test |
Implemented the
box.Schema()method that returns aSchemaobject for schema-related operations.Co-authored-by: maksim.konovalov [email protected]