datetime: add TZ support #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-163-datetime-tz
branch
from
dde0ab8 to
eda01e1
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-163-datetime-tz
branch
from
eda01e1 to
eabefed
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-163-datetime-tz
branch
5 times, most recently
from
2fbb50b to
e51a5b3
Compare
DifferentialOrange
approved these changes
Aug 5, 2022
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-163-datetime-tz
branch
2 times, most recently
from
54d5676 to
938d44b
Compare
|
I've made a separate pull request to fix golangci-lint errors: We can ignore it here. |
DifferentialOrange
approved these changes
Aug 5, 2022
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-163-datetime-tz
branch
3 times, most recently
from
6082fb5 to
f317da8
Compare
After the patch all messages in datetime tests start with a capital letter. All errors start with a lowecase letter [1]. 1. https://github.com/golang/go/wiki/CodeReviewComments#error-strings
The patch adds timezone support [1] for datetime. For the purpose of compatibility we got constants for timezones from Tarantool [2]. The patch adds a script to generate the data according to the instructions [3]. 1. https://github.com/tarantool/tarantool/wiki/Datetime-Internals#timezone-support 2. https://github.com/tarantool/tarantool/blob/9ee45289e01232b8df1413efea11db170ae3b3b4/src/lib/tzcode/timezones.h 3. https://github.com/tarantool/tarantool/blob/9ee45289e01232b8df1413efea11db170ae3b3b4/src/lib/tzcode/gen-zone-abbrevs.pl#L35-L39 Closes #163
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-163-datetime-tz
branch
from
f317da8 to
f100dc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch adds timezone support [1] for datetime. For the purpose of compatibility we got constants for timezones from Tarantool [2]. The patch adds a script to generate the data according to the instructions [3].
I didn't forget about (remove if it is not applicable):
Related issues:
Closes #163