api: remove NewErrorFuture #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
force-pushed
the
oleg-jukovec/remove-NewErrorFuture
branch
3 times, most recently
from
457824f to
0f3cf4d
Compare
At least, not necessary and, maybe, named in not a very obvious way. I'm okay to move it from the public API. |
oleg-jukovec
changed the title
oleg-jukovec
changed the title
It was introduced in e9b9ba1 . The function looks strange in the public API. The patch moves it to the connection_pool's internal implementation.
oleg-jukovec
force-pushed
the
oleg-jukovec/remove-NewErrorFuture
branch
from
0f3cf4d to
0fd6c03
Compare
vr009
approved these changes
Jun 29, 2022
oleg-jukovec
added a commit
that referenced
this pull request
Jul 27, 2022
Overview
This release adds a number of features. The extending of the public API
has become possible with a new way of creating requests. New types of
requests are created via chain calls:
selectReq := NewSelectRequest("space").
Context(ctx).
Index(1).
Offset(5).
Limit(10)
future := conn.Do(selectReq)
Streams, context and prepared statements support are based on this
idea:
stream, err := conn.NewStream()
beginReq := NewBeginRequest().Context(ctx)
if response, err := stream.Do(beginReq).Get(); err != nil {
selectFuture := stream.Do(selectReq)
commitFuture := stream.Do(NewCommitRequest())
// ...
}
```
Breaking changes
NewErrorFuture function removed (#190).
`IPROTO_*` constants that identify requests renamed from
`<Name>Request` to `<Name>RequestCode` (#126)
New features
SSL support (#155).
IPROTO_PUSH messages support (#67).
Public API with request object types (#126).
Support decimal type in msgpack (#96).
Support datetime type in msgpack (#118).
Prepared SQL statements (#117).
Streams and interactive transactions support (#101).
`Call16` method, support build tag `go_tarantool_call_17`
to choose default behavior for `Call` method as Call17 (#125)
Bugfixes
Add `ExecuteAsync` and `ExecuteTyped` to common connector
interface (#62).
Merged
oleg-jukovec
added a commit
that referenced
this pull request
Aug 2, 2022
Overview
This release adds a number of features. The extending of the public API
has become possible with a new way of creating requests. New types of
requests are created via chain calls:
selectReq := NewSelectRequest("space").
Context(ctx).
Index(1).
Offset(5).
Limit(10)
future := conn.Do(selectReq)
Streams, context and prepared statements support are based on this
idea:
stream, err := conn.NewStream()
beginReq := NewBeginRequest().Context(ctx)
if response, err := stream.Do(beginReq).Get(); err != nil {
selectFuture := stream.Do(selectReq)
commitFuture := stream.Do(NewCommitRequest())
// ...
}
```
Breaking changes
NewErrorFuture function removed (#190).
`IPROTO_*` constants that identify requests renamed from
`<Name>Request` to `<Name>RequestCode` (#126)
New features
SSL support (#155).
IPROTO_PUSH messages support (#67).
Public API with request object types (#126).
Support decimal type in msgpack (#96).
Support datetime type in msgpack (#118).
Prepared SQL statements (#117).
Streams and interactive transactions support (#101).
`Call16` method, support build tag `go_tarantool_call_17`
to choose default behavior for `Call` method as Call17 (#125)
Bugfixes
Add `ExecuteAsync` and `ExecuteTyped` to common connector
interface (#62).
oleg-jukovec
added a commit
that referenced
this pull request
Aug 3, 2022
Overview
This release adds a number of features. The extending of the public API
has become possible with a new way of creating requests. New types of
requests are created via chain calls:
selectReq := NewSelectRequest("space").
Context(ctx).
Index(1).
Offset(5).
Limit(10)
future := conn.Do(selectReq)
Streams, context and prepared statements support are based on this
idea:
stream, err := conn.NewStream()
beginReq := NewBeginRequest().Context(ctx)
if response, err := stream.Do(beginReq).Get(); err != nil {
selectFuture := stream.Do(selectReq)
commitFuture := stream.Do(NewCommitRequest())
// ...
}
```
Breaking changes
NewErrorFuture function removed (#190).
`IPROTO_*` constants that identify requests renamed from
`<Name>Request` to `<Name>RequestCode` (#126)
New features
SSL support (#155).
IPROTO_PUSH messages support (#67).
Public API with request object types (#126).
Support decimal type in msgpack (#96).
Support datetime type in msgpack (#118).
Prepared SQL statements (#117).
Context support for request objects (#48).
Streams and interactive transactions support (#101).
`Call16` method, support build tag `go_tarantool_call_17`
to choose default behavior for `Call` method as Call17 (#125)
Bugfixes
Add `ExecuteAsync` and `ExecuteTyped` to common connector
interface (#62).
oleg-jukovec
added a commit
that referenced
this pull request
Aug 4, 2022
Overview
This release adds a number of features. The extending of the public API
has become possible with a new way of creating requests. New types of
requests are created via chain calls:
selectReq := NewSelectRequest("space").
Context(ctx).
Index(1).
Offset(5).
Limit(10)
future := conn.Do(selectReq)
Streams, context and prepared statements support are based on this
idea:
stream, err := conn.NewStream()
beginReq := NewBeginRequest().Context(ctx)
if response, err := stream.Do(beginReq).Get(); err != nil {
selectFuture := stream.Do(selectReq)
commitFuture := stream.Do(NewCommitRequest())
// ...
}
```
Breaking changes
NewErrorFuture function removed (#190).
`IPROTO_*` constants that identify requests renamed from
`<Name>Request` to `<Name>RequestCode` (#126)
New features
SSL support (#155).
IPROTO_PUSH messages support (#67).
Public API with request object types (#126).
Support decimal type in msgpack (#96).
Support datetime type in msgpack (#118).
Prepared SQL statements (#117).
Context support for request objects (#48).
Streams and interactive transactions support (#101).
`Call16` method, support build tag `go_tarantool_call_17`
to choose default behavior for `Call` method as Call17 (#125)
Bugfixes
Add `ExecuteAsync` and `ExecuteTyped` to common connector
interface (#62).
oleg-jukovec
added a commit
that referenced
this pull request
Aug 4, 2022
Overview
This release adds a number of features. The extending of the public API
has become possible with a new way of creating requests. New types of
requests are created via chain calls:
selectReq := NewSelectRequest("space").
Context(ctx).
Index(1).
Offset(5).
Limit(10)
future := conn.Do(selectReq)
Streams, context and prepared statements support are based on this
idea:
stream, err := conn.NewStream()
beginReq := NewBeginRequest().Context(ctx)
if response, err := stream.Do(beginReq).Get(); err != nil {
selectFuture := stream.Do(selectReq)
commitFuture := stream.Do(NewCommitRequest())
// ...
}
```
Breaking changes
NewErrorFuture function removed (#190).
`IPROTO_*` constants that identify requests renamed from
`<Name>Request` to `<Name>RequestCode` (#126)
New features
SSL support (#155).
IPROTO_PUSH messages support (#67).
Public API with request object types (#126).
Support decimal type in msgpack (#96).
Support datetime type in msgpack (#118).
Prepared SQL statements (#117).
Context support for request objects (#48).
Streams and interactive transactions support (#101).
`Call16` method, support build tag `go_tarantool_call_17`
to choose default behavior for `Call` method as Call17 (#125)
Bugfixes
Add `ExecuteAsync` and `ExecuteTyped` to common connector
interface (#62).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done? Why? What problem is being solved?
Before we do a release 1.7.0 I propose a little change: remove NewErrorFuture function from the public API.
It was introduced in e9b9ba1 . The function looks strange in the public API. The patch moves it to the connection_pool's internal implementation.
I didn't forget about (remove if it is not applicable):