This repository was archived by the owner on Apr 6, 2021. It is now read-only.
Fallback to non variant matches when no matching variant exists #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Svelte’s dynamic class syntax looks like this:
<h1 class:text-blue-500={shouldBeBlue}></h1>
We were picking up `class:text-blue-500` as a variant. However `class` is not a registered variant. In this case we were discarding the already matched rules for text-blue-500. In this case we want to match them anyway.
If multiple candidates resolved to the same rule the properties would get added more than once to the same rule. For instance: class:text-blue-500 class1:text-blue-500 class2:text-blue-500 results in .text-blue-500 having the properties set 3 times.
|
Closing since #183 was merged. |
|
Thanks though! ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #71
Svelte’s dynamic class syntax looks like this:
<h1 class:text-blue-500={shouldBeBlue}></h1>We were picking up
class:text-blue-500as a variant. Howeverclassis not a registered variant. In this case we were discarding the already matched rules for text-blue-500. In this case we want to match them anyway.