This repository was archived by the owner on Apr 6, 2021. It is now read-only.
Fix context cache when using literal config object instead of file #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradlc
commented
Mar 12, 2021
| contextMap.set(sourcePath, context) | ||
| return context | ||
| // If the config used already exists in the cache, return that. | ||
| if (configContextMap.has(tailwindConfigHash)) { |
There was a problem hiding this comment.
Does this need && !isConfigFile?
There was a problem hiding this comment.
I... don't know 😅 I don't think so, I think this is right. If we don't have a context in the map for the current source path (real world example is MyComponent.vue with a style block), we want to try and reuse the context based on the config hash and then set up that source path in the map. True even if there's a config file if I'm not missing something.
|
I just tried this branch on Nuxt + Webpack + Tailwind module and it fixes the HMR issue when using the config object 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.