Fix support for empty attributes #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
This change adds handling for attributes that are explicitly set with an empty string
""
or all whitespace" "
.Prior to this, html comments that contained an empty string attribute were ignored completely.
For example, given the following html
commentMarker
returnsnull
.Additionally, attributes with whitespace only were coerced to
number
resulting in unexpected behavior.For example, the following results in an attribute value of
0
.