Skip to content

Allow spaces inside marker even when it has no attributes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Allow spaces inside marker even when it has no attributes #2

wants to merge 1 commit into from

Conversation

izumin5210
Copy link

Currently, this util returns null given the following node...

{
  type: 'html',
  value: '<!-- foo -->'
}

@wooorm wooorm closed this in c2ce95c May 29, 2017
@wooorm
Copy link
Member

wooorm commented May 29, 2017

Whoops, I missed your PR! 😬 Thanks for fixing this, I can’t believe it wasn’t handled properly! 🎉

I’ll release this in a minute!

@izumin5210
Copy link
Author

thanks for releasing! 🎉

@izumin5210 izumin5210 deleted the allow-spaces branch May 29, 2017 10:40
@izumin5210 izumin5210 restored the allow-spaces branch May 29, 2017 14:57
@wooorm wooorm added ⛵️ status/released 🐛 type/bug This is a problem 🗄 area/interface This affects the public interface 👶 semver/patch This is a backwards-compatible fix labels Aug 12, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@izumin5210 @wooorm