Skip to content

Disable URL handling #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
XWB opened this issue Jun 10, 2018 · 1 comment
Closed

Disable URL handling #334

XWB opened this issue Jun 10, 2018 · 1 comment
Labels
Feature New Feature HasPR

Comments

@XWB
Copy link
Contributor

XWB commented Jun 10, 2018 •
edited
Loading

The webpack css-loader has the ability to disable url handling by setting the following option to false:

https://github.com/webpack-contrib/css-loader#url

As far as I can see, Encore has no ability to pass this setting through Webpack. I would be nice to have this ability.
@weaverryan
Copy link
Member

Hmmm, that’s probably true - nobody has needed to pass/configure css-loader options before. A PR would definitely be considered - makes sense to me

@XWB XWB mentioned this issue Jun 11, 2018
Merged
@Lyrkan Lyrkan added Feature New Feature HasPR labels Jun 20, 2018
weaverryan added a commit that referenced this issue Jul 14, 2018
@weaverryan
feature #335 Add option to configure the CSS loader (XWB)
63e15ce 
This PR was merged into the master branch.

Discussion
----------

Add option to configure the CSS loader

Disabling the URL handler can be handy for importing legacy CSS.

Fixes #334

Commits
-------

64935f1 Add css-loader configuration callback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New Feature HasPR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@weaverryan @Lyrkan @XWB