Skip to content

Commit d8093ad

Browse files
authored
minor #400 Use a different priority for each plugin (Lyrkan)
2 parents c5ae324 + 3c519e3 commit d8093ad

File tree

3 files changed

+19
-19
lines changed

3 files changed

+19
-19
lines changed

lib/plugins/entry-files-manifest.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,6 @@ module.exports = function(plugins, webpackConfig) {
2929
[sharedEntryTmpName],
3030
webpackConfig.styleEntries
3131
),
32-
priority: PluginPriorities.DeleteUnusedEntriesJSPlugin
32+
priority: PluginPriorities.EntryFilesManifestPlugin
3333
});
3434
};

lib/plugins/plugin-priorities.js

+14-14
Original file line numberDiff line numberDiff line change
@@ -10,20 +10,20 @@
1010
'use strict';
1111

1212
module.exports = {
13-
MiniCssExtractPlugin: 0,
14-
DeleteUnusedEntriesJSPlugin: 0,
15-
WebpackManifestPlugin: 0,
16-
SharedEntryContactPlugin: 0,
17-
LoaderOptionsPlugin: 0,
18-
ProvidePlugin: 0,
19-
CleanWebpackPlugin: 0,
20-
DefinePlugin: 0,
21-
FriendlyErrorsWebpackPlugin: 0,
22-
AssetOutputDisplayPlugin: 0,
23-
ForkTsCheckerWebpackPlugin: 0,
13+
MiniCssExtractPlugin: 140,
14+
DeleteUnusedEntriesJSPlugin: 130,
15+
WebpackManifestPlugin: 120,
16+
LoaderOptionsPlugin: 110,
17+
WebpackChunkHash: 100,
18+
ProvidePlugin: 90,
19+
CleanWebpackPlugin: 80,
20+
DefinePlugin: 70,
21+
WebpackNotifier: 60,
22+
VueLoaderPlugin: 50,
23+
FriendlyErrorsWebpackPlugin: 40,
24+
AssetOutputDisplayPlugin: 30,
25+
SharedEntryContactPlugin: 20,
26+
ForkTsCheckerWebpackPlugin: 10,
2427
HashedModuleIdsPlugin: 0,
25-
WebpackChunkHash: 0,
26-
WebpackNotifier: 0,
27-
VueLoaderPlugin: 0,
2828
EntryFilesManifestPlugin: -10,
2929
};

test/config-generator.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -592,7 +592,7 @@ describe('The config-generator function', () => {
592592
expect(ignorePlugin).to.not.be.undefined;
593593
});
594594

595-
it('by default custom plugins are added at the end and are kept in order', () => {
595+
it('by default custom plugins are added after the last plugin with a priority of 0 and are kept in order', () => {
596596
const config = createConfig();
597597
config.outputPath = '/tmp/public/build';
598598
config.setPublicPath('/build/');
@@ -603,9 +603,9 @@ describe('The config-generator function', () => {
603603
const actualConfig = configGenerator(config);
604604
const plugins = actualConfig.plugins;
605605

606-
expect(plugins[plugins.length - 3]).to.be.instanceof(CustomPlugin1);
607-
expect(plugins[plugins.length - 2]).to.be.instanceof(CustomPlugin2);
608-
expect(plugins[plugins.length - 1]).to.be.instanceof(CustomPlugin3);
606+
expect(plugins[plugins.length - 4]).to.be.instanceof(CustomPlugin1);
607+
expect(plugins[plugins.length - 3]).to.be.instanceof(CustomPlugin2);
608+
expect(plugins[plugins.length - 2]).to.be.instanceof(CustomPlugin3);
609609
});
610610

611611
it('plugins can be sorted relatively to each other', () => {

0 commit comments

Comments
 (0)