bug #394 Filter --keep-public-path from arguments (fixes #180) (x539)

Author: Lyrkan

bin/encore.js

@@ -29,6 +29,10 @@ if (runtimeConfig.outputJson) {
 // remove the command from the input
 process.argv.splice(2, 1);
 
+// remove arguments not supported by webpack/-dev-server
+const encoreOnlyArguments = new Set(['--keep-public-path']);
+process.argv = process.argv.filter(arg => !encoreOnlyArguments.has(arg));
+
 if (!runtimeConfig.isValidCommand) {
     if (runtimeConfig.command) {
         console.log(chalk.bgRed.white(`Invalid command "${runtimeConfig.command}"`));

test/bin/encore.js

@@ -114,4 +114,32 @@ module.exports = Encore.getWebpackConfig();
             done();
         });
     });
+
+    it('Smoke test using the --keep-public-path option', (done) => {
+        testSetup.emptyTmpDir();
+        const testDir = testSetup.createTestAppDir();
+
+        fs.writeFileSync(
+            path.join(testDir, 'webpack.config.js'),
+            `
+const Encore = require('../../index.js');
+Encore
+    .setOutputPath('build/')
+    .setPublicPath('/build')
+    .addEntry('main', './js/no_require')
+;
+
+module.exports = Encore.getWebpackConfig();
+            `
+        );
+
+        const binPath = path.resolve(__dirname, '../', '../', 'bin', 'encore.js');
+        exec(`node ${binPath} dev --keep-public-path --context=${testDir}`, { cwd: testDir }, (err, stdout, stderr) => {
+            if (err) {
+                throw new Error(`Error executing encore: ${err} ${stderr} ${stdout}`);
+            }
+
+            done();
+        });
+    });
 });