Skip to content

Commit bcabda6

Browse files
committed
Add some missing 'return' statements
1 parent 0161000 commit bcabda6

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

scripts/force-lowest-dependencies.js

+5
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ function getLowestVersion(dependency, range) {
2020
(error, stdout) => {
2121
if (error) {
2222
reject(`Could not retrieve versions list for "${dependency}@${range}"`);
23+
return;
2324
}
2425

2526
const versions = stdout
@@ -28,6 +29,7 @@ function getLowestVersion(dependency, range) {
2829

2930
if (versions.length === 0) {
3031
reject(`Could not find a lowest version for "${dependency}@${range}"`);
32+
return;
3133
}
3234

3335
const parts = versions[0].split(' ');
@@ -36,13 +38,15 @@ function getLowestVersion(dependency, range) {
3638
// is directly printed as the output of npm view.
3739
if (parts.length === 1) {
3840
resolve([dependency, parts[0]]);
41+
return;
3942
}
4043

4144
// If multiple versions are available then it outputs
4245
// multiple lines matching the following format:
4346
// <package>@<version> '<version>'
4447
if (parts.length === 2) {
4548
resolve([dependency, parts[1].replace(/'/g, '')]);
49+
return;
4650
}
4751

4852
reject(`Unexpected response for "${dependency}@${range}": ${versions[0]}`);
@@ -98,6 +102,7 @@ fs.readFile('package.json', (error, data) => {
98102
fs.writeFile('package.json', JSON.stringify(packageInfo, null, 2), (error) => {
99103
if (error) {
100104
reject(error);
105+
return;
101106
}
102107

103108
resolve();

0 commit comments

Comments
 (0)