Skip to content

Commit 0161000

Browse files
committed
Remove hardcoded sass-loader version in addPackagesVersionConstraint test
1 parent 7abea75 commit 0161000

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

test/package-helper.js

+7-3
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ const expect = require('chai').expect;
1313
const packageHelper = require('../lib/package-helper');
1414
const path = require('path');
1515
const process = require('process');
16+
const fs = require('fs');
1617

1718
describe('package-helper', () => {
1819
const baseCwd = process.cwd();
@@ -135,14 +136,17 @@ describe('package-helper', () => {
135136

136137
describe('addPackagesVersionConstraint', () => {
137138
it('Lookup a version constraint', () => {
138-
// hardcoding sass-loader: test WILL break when this changes
139-
140139
const inputPackages = [
141140
{ name: 'sass-loader', enforce_version: 7 },
142141
{ name: 'node-sass' }
143142
];
143+
144+
const packageInfo = JSON.parse(
145+
fs.readFileSync(path.join(__dirname, '../package.json'))
146+
);
147+
144148
const expectedPackages = [
145-
{ name: 'sass-loader', version: '^7.0.1' },
149+
{ name: 'sass-loader', version: packageInfo.devDependencies['sass-loader'] },
146150
{ name: 'node-sass' }
147151
];
148152

0 commit comments

Comments
 (0)