[Security][Guard] Added a picture for Guard Authenticator #7280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thentication Guard methods.
|
Looks great! Beware that returning null from |
|
You are right @ogizanagi, but it is always a big question: either to put all details to a picture or keep it simpler. |
|
Thank you for this really beautiful improvement @a-ast! |
xabbuh
added a commit
that referenced
this pull request
May 17, 2017
… (a-ast) This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #7280). Discussion ---------- [Security][Guard] Added a picture for Guard Authenticator This illustration shows how GuardAuthenticationListener calls methods of Guard Authenticator. Commits ------- ed0e6da Added the picture that shows how GuardAuthenticationListener calls Authentication Guard methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This illustration shows how GuardAuthenticationListener calls methods of Guard Authenticator.