Skip to content

fix code example #10421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2018
Merged

fix code example #10421

merged 1 commit into from
Oct 2, 2018

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Oct 1, 2018

No description provided.

@xabbuh xabbuh added this to the 2.8 milestone Oct 1, 2018
javiereguiluz
javiereguiluz approved these changes Oct 1, 2018
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I remember having some troubles when merging the original PR into upper branches because all this is reworded/deleted in newer Symfony versions. Could you please merge this PR yourself so I don't introduce issues again here? Thanks! 😊

@xabbuh xabbuh merged commit 7c82782 into symfony:2.8 Oct 2, 2018
xabbuh added a commit that referenced this pull request Oct 2, 2018
@xabbuh
minor #10421 fix code example (xabbuh)
6df3ca4 
This PR was merged into the 2.8 branch.

Discussion
----------

fix code example

Commits
-------

7c82782 fix code example
@xabbuh xabbuh deleted the pr-9329 branch October 2, 2018 09:48
@xabbuh
Copy link
Member Author

xabbuh commented Oct 2, 2018

@javiereguiluz done

@javiereguiluz
Copy link
Member

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @javiereguiluz @carsonbot