Skip to content

[Security][Guard] Deprecated GuardAuthenticatorInterface #8485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chalasr opened this issue Oct 5, 2017 · 0 comments
Closed

[Security][Guard] Deprecated GuardAuthenticatorInterface #8485

chalasr opened this issue Oct 5, 2017 · 0 comments
Labels
actionable Clear and specific issues ready for anyone to take them. hasPR A Pull Request has already been submitted for this issue. Security
Milestone
3.4

Comments

@chalasr
Copy link
Member

chalasr commented Oct 5, 2017 •
edited
Loading

As of 3.4

  • GuardAuthenticatorInterface is deprecated and will be removed in 4.0, references should be updated to use AuthenticatorInterface instead (starting from 3.4);
  • AuthenticatorInterface introduces a supports() method used to skip authenticators which are not able to process authentication from the given request, any authenticator must implement it
  • GuardAuthenticatorInterface::getCredentials() returning null causes the authenticator to be skipped. This behavior has been removed in the new AuthenticatorInterface, returning null from AuthenticatorInterface::getCredentials() throws an \UnexpectedValueException exception (false should be returned from supports() instead)

Code PR: symfony/symfony#16835
@chalasr chalasr mentioned this issue Oct 5, 2017
Merged
fabpot added a commit to symfony/symfony that referenced this issue Oct 5, 2017
@fabpot
feature #24446 [Security] Remove GuardAuthenticatorInterface (chalasr)
75fe1fc 
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Security] Remove GuardAuthenticatorInterface

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | symfony/symfony-docs#8485

Removes BC layers for #16835.

Commits
-------

3408152 [Security][Guard] Remove GuardAuthenticatorInterface
@xabbuh xabbuh added this to the 3.4 milestone Oct 6, 2017
@xabbuh xabbuh added actionable Clear and specific issues ready for anyone to take them. Guard Security labels Oct 6, 2017
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Oct 9, 2017
@javiereguiluz javiereguiluz mentioned this issue Oct 9, 2017
Closed
xabbuh added a commit that referenced this issue Oct 13, 2017
@xabbuh
minor #8497 Updated Guard article for the GuardAuthenticatorInterface…
2ed7ac0 
… deprecation (javiereguiluz)

This PR was squashed before being merged into the 3.4 branch (closes #8497).

Discussion
----------

Updated Guard article for the GuardAuthenticatorInterface deprecation

This fixes #8485.

Commits
-------

e889c94 Updated Guard article for the GuardAuthenticatorInterface deprecation
@xabbuh xabbuh closed this as completed Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. hasPR A Pull Request has already been submitted for this issue. Security
Projects
None yet
Milestone
3.4
Development

No branches or pull requests
3 participants
@javiereguiluz @xabbuh @chalasr