[Website] Bad syntax highlighting

[iamdto]

It looks like syntax highlighting is broken on some code blocks. For example on the framework full default configuration. I've noticed this in some blog posts too (the first Monolog configuration block for example).

Not sure if it's a bug or a feature, though.

[stof]

This is because we have some unquoted values starting with %. While this is valid in YAML 1.2 (there is no ambiguity with YAML directives in this context), it was not valid in YAML 1.1, and the Pygment syntax highlighter for YAML was based on the 1.1 spec, and so is not able to highlight this code.
The fix done in other parts of the doc is to switch to quoted values for these cases

[iamdto]

Thanks @stof, I've added some comments in #4030.

[xabbuh]

I guess with #4030 being merged now, this can be closed.

[wouterj]

At least, the documentation issues in this issue are now fixed.

Thanks you, @iamdto for you help in catching and finding the problematic spots in the docs!

@javiereguiluz can you please fix the blog post?

[javiereguiluz]

@wouterj I don't know what we should fix in the blog post. The first YAML code block appears with the right colors (but unnumbered). Is that correct?

[wouterj]

@javiereguiluz this is what I'm seeing:

It doesn't have the right colors (only background color) and it is unnumbered because the highlighter isn't executed. That's because it contains an "error" (it was an error in Yaml 1.0). You should update it like this:

monolog:
    handlers:
        main:
            type:   stream
---            path:   %kernel.logs_dir%/%kernel.environment%.log
+++            path:   "%kernel.logs_dir%/%kernel.environment%.log"
            level:  debug
        console:
            type:   console

[javiereguiluz]

@wouterj thanks for the explanation :)

@Tobion could you please edit this blog post that you published and enclose the value of the path parameter with quotes? Thank you! This is the post: http://symfony.com/blog/new-in-symfony-2-4-show-logs-in-console

[Tobion]

Cool I can edit this. This is new. I've updated it.

[xabbuh]

👍

[wouterj]

Thanks @Tobion !