Skip to content

Remove baseline tests (e.g. “Call JavaScript function directly”) from comparison #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Remove baseline tests (e.g. “Call JavaScript function directly”) from comparison #211

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de57364
Remove baseline tests (e.g. “Call JavaScript function directly”) from…
j-f1 Sep 19, 2022
4e10937
)
j-f1 Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ci/perf-tester/src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ exports.diffTable = (
) => {
let changedRows = [];
let unChangedRows = [];
let baselineRows = [];

let totalTime = 0;
let totalDelta = 0;
Expand All @@ -187,7 +188,9 @@ exports.diffTable = (
getDeltaText(delta, difference),
iconForDifference(difference),
];
if (isUnchanged && collapseUnchanged) {
if (name.includes('directly')) {
baselineRows.push(columns);
} else if (isUnchanged && collapseUnchanged) {
unChangedRows.push(columns);
} else {
changedRows.push(columns);
Expand All @@ -200,6 +203,11 @@ exports.diffTable = (
const outUnchanged = markdownTable(unChangedRows);
out += `\n\n<details><summary><strong>View Unchanged</strong></summary>\n\n${outUnchanged}\n\n</details>\n\n`;
}

if (baselineRows.length !== 0) {
const outBaseline = markdownTable(baselineRows.map(line => line.slice(0, 2)));
out += `\n\n<details><summary><strong>View Baselines</strong></summary>\n\n${outBaseline}\n\n</details>\n\n`;
}

if (showTotal) {
const totalDifference = ((totalDelta / totalTime) * 100) | 0;
Expand Down