Create local functions to validate the RawSyntax layout of nodes #2908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
rintaro
approved these changes
Dec 3, 2024
|
@swift-ci Please test macOS |
Having the validation code in a single switch statement overflows the stack in debug builds. Keep the `switch` small and extract the validation logic into separate functions, similar to what we do for `SyntaxVisitor` to work around rdar://55929175
ahoppen
force-pushed
the
rawsyntaxvalidation-stack-usage
branch
from
43a091a to
704b199
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the validation code in a single switch statement overflows the stack in debug builds. Keep the
switchsmall and extract the validation logic into separate functions, similar to what we do forSyntaxVisitorto work around rdar://55929175