Support parsing of key path subscripts on metatypes #2871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
rintaro
reviewed
Oct 3, 2024
Sources/SwiftParser/Types.swift
Outdated
| @@ -260,7 +259,9 @@ extension Parser { | |||
|
|
|||
| var loopProgress = LoopProgressCondition() | |||
| while self.hasProgressed(&loopProgress) { | |||
| if !stopAtFirstPeriod, self.at(.period) { | |||
| if allowMemberTypes || (self.at(.period) && self.peek(isAt: .keyword(.Type), .keyword(.Protocol))), | |||
There was a problem hiding this comment.
What about nested types like: \Foo.Bar.[0]?
ahoppen
force-pushed
the
metatype-keypath
branch
from
1dc6bad to
0a74d2f
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
@swift-ci Please test Linux |
1 similar comment
|
@swift-ci Please test Linux |
rintaro
reviewed
Oct 4, 2024
| if self.at(TokenSpec(.leftSquare, allowAtStartOfLine: false)) | ||
| || (components.isEmpty && self.at(.period) && self.peek(isAt: .leftSquare)) | ||
| || (components.allSatisfy({ $0.component.is(RawKeyPathPropertyComponentSyntax.self) }) && self.at(.period) |
There was a problem hiding this comment.
I found \T.?.? is currently accepted, it also need this check.
Also, could this components.allSatisfy() check be a flag outside the loop?
There was a problem hiding this comment.
Updated to disallow these key paths. I found a fun example along the way that’s valid 😭. This prevents us from diagnosing the . as an unexpected token, which would generally be nicer diagnostics.
struct Foo {
var bar: Int?
}
infix operator .?.
func .?.(_ x: AnyKeyPath, _ a: Int) {}
var blah = 2
\Foo?.?.bar.?.blah
ahoppen
force-pushed
the
metatype-keypath
branch
from
0a74d2f to
7b52d07
Compare
rintaro
approved these changes
Oct 9, 2024
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to support parsing eg.
https://github.com/swiftlang/swift/pull/73242/files#diff-a94f38549dc87ce27c438b255ae2f29c69cc1c2c5e5069f327c5c7fae7bc553dR667