[CodeGeneration] Unify handling for node choices #2827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Aug 27, 2024
CodeGeneration/Sources/generate-swift-syntax/ChildNodeChoices.swift
Outdated
Show resolved
Hide resolved
CodeGeneration/Sources/generate-swift-syntax/ChildNodeChoices.swift
Outdated
Show resolved
Hide resolved
AppAppWorks
force-pushed
the
unify-code-generation-node-choices
branch
2 times, most recently
from
bf35b3a to
147718f
Compare
ahoppen
reviewed
Aug 28, 2024
There was a problem hiding this comment.
Only open discussion is https://github.com/swiftlang/swift-syntax/pull/2827/files#r1733633656, otherwise LGTM.
CodeGeneration/Sources/generate-swift-syntax/ChildNodeChoices.swift
Outdated
Show resolved
Hide resolved
- unified code generation for node choices across raw and non-raw sides - fixed missing doc comments, experimental note, and api attributes for node choices enum cases - improved serial IfExpr generation
AppAppWorks
force-pushed
the
unify-code-generation-node-choices
branch
from
147718f to
4d6b90a
Compare
|
I've changed the generation of ifExpr from recursion-based to iteration-based, LGTM :) |
|
This PR should be ready for ci-test now :) |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are three separate implementations for generating node choices enum on the raw and non-raw sides, resulting in code duplication and inconsistencies. Besides, documentation, experimental note, and api attributes have also been omitted in the generation of node choices enum.
This PR aims to fix these issues by unifying and rectifying the facilities for code generation.