Skip to content

[6.0][CMake] Enable package CMO only in newer compiler #2765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2024
Merged

[6.0][CMake] Enable package CMO only in newer compiler #2765

merged 1 commit into from
Jul 30, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jul 30, 2024 •
edited by bnbarham
Loading

Cherry-pick #2764 into release/6.0

  • Explanation: Restricts enabling package CMO to only toolchains that properly support it to avoid linkage errors.
  • Scope: swift-syntax
  • Risk: Very low, disables package CMO in more cases
  • Testing: No extra tests, this is a build time issue
  • Issue: rdar://132708551
  • Reviewer: Ben Barham (@bnbarham)

@rintaro rintaro requested review from ahoppen and bnbarham as code owners July 30, 2024 00:35
@rintaro
Copy link
Member Author

rintaro commented Jul 30, 2024

@swift-ci Please test

@rintaro rintaro changed the title [CMake] Enable package CMO only in newer compiler [6.0][CMake] Enable package CMO only in newer compiler Jul 30, 2024
@rintaro rintaro enabled auto-merge July 30, 2024 00:46
@rintaro rintaro mentioned this pull request Jul 30, 2024
Closed
@rintaro rintaro merged commit 06b5cdc into swiftlang:release/6.0 Jul 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rintaro @bnbarham @ahoppen