Emit a warning if a conformance to MemberMacro does not contain the expansion method that takes a conformingTo parameter
#2754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `expansion` method that takes a `conformingTo` parameter The `expansion` method that takes a `conformingTo` has been defaulted to be source-compatible with older versions of swift-syntax that required a version of the `expansion` function without the `conformingTo` parameter. That meant that you could state a conformance to `MemberMacro` without implementing any methods and you wouldn’t get any compile time diagnostics. Deprecate the forwarding default implementation so that you get a warning if you are relying on it.
|
@swift-ci Please test |
bnbarham
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
expansionmethod that takes aconformingTohas been defaulted to be source-compatible with older versions of swift-syntax that required a version of theexpansionfunction without theconformingToparameter.That meant that you could state a conformance to
MemberMacrowithout implementing any methods and you wouldn’t get any compile time diagnostics.Deprecate the forwarding default implementation so that you get a warning if you are relying on it.