Turn some static variables into static stored constants #2729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returnning array literal from computed property allocates and initializes the array buffer every time it's called, and they are deallocated after use. Make them stored properties so they stay in memory.
Building standard operator table is not trivial. Make is an immutable stored property so it stays in memory once it's initialized.
|
@swift-ci Please test |
ahoppen
approved these changes
Jul 16, 2024
| return nil | ||
| } | ||
| guard case .layout(let childrenKeyPaths) = parent.kind.syntaxNodeType.structure else { | ||
| guard case .layout(let childrenKeyPaths) = self._syntaxNode.parent?.kind.syntaxNodeType.structure else { |
There was a problem hiding this comment.
Is self._syntaxNode.parent faster than parent?
There was a problem hiding this comment.
That was my measurement, but I'm not 100% sure tbh. I will double check.
There was a problem hiding this comment.
Removed this commit from the PR for now
rintaro
force-pushed
the
static-stored-constant
branch
from
0477185 to
fad2743
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computing
OperatorTable.standardOperatorsis not trivial, make itstatic letinstead of computed static variable.So as
SyntaxProtocol.structureimplementations.