Skip to content

[6.0][Package] Underscore "internal" products #2706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 26, 2024

Cherry-pick #2703 into release/6.0

  • Explanation: SwiftCompilerPluginMessageHandling and SwiftLibraryPluginProvider modules are only meant to be used by internal components. Underscore the naming of the products for these modules to prevent other users try to use them accidentally. Also, stop generating documents for these products by skipping the underscored product names in swift-syntax-dev-utils verify-source-code
  • Scope: SwiftPM package description
  • Risk: Low. These product names in the SwiftPM package are not used to build toolchains.
  • Testing: Passes current test suite
  • Issue: N/A
  • Reviewer: Ben Barham (@bnbarham) Alex Hoppen (@ahoppen)

SwiftCompilerPluginMessageHandling and SwiftLibraryPluginProvider are
only meant to be used by internal components

(cherry picked from commit 37ec703)
@rintaro rintaro requested review from ahoppen and bnbarham as code owners June 26, 2024 16:48
@rintaro rintaro changed the title [Package] Underscore "internal" products [6.0][Package] Underscore "internal" products Jun 26, 2024
@rintaro
Copy link
Member Author

rintaro commented Jun 26, 2024

@swift-ci Please test

1 similar comment
@rintaro
Copy link
Member Author

rintaro commented Jul 20, 2024

@swift-ci Please test

@rintaro rintaro enabled auto-merge July 20, 2024 02:03
@rintaro rintaro merged commit 3470ac1 into swiftlang:release/6.0 Jul 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants