Skip to content

[6.0] Fix Bazel build adding generic test support libraries #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

SimplyDanny
Copy link
Contributor

@SimplyDanny SimplyDanny commented Jun 22, 2024

@SimplyDanny SimplyDanny requested a review from keith as a code owner June 22, 2024 12:30
@keith
Copy link
Member

keith commented Jun 22, 2024

@swift-ci please test

@keith keith changed the title Fix Bazel build adding generic test support libraries [6.0] Fix Bazel build adding generic test support libraries Jun 22, 2024
@keith keith requested a review from ahoppen June 22, 2024 17:50
@keith
Copy link
Member

keith commented Jun 22, 2024

lgtm! thanks! verified locally everything builds with this. adding @ahoppen since they said they should merge 6.x PRs and not me

@keith
Copy link
Member

keith commented Jun 22, 2024

Here's a related main PR for this one: #2694

@ahoppen ahoppen requested a review from bnbarham June 24, 2024 14:03
@ahoppen ahoppen merged commit d9d0ef3 into swiftlang:release/6.0 Jun 25, 2024
3 checks passed
@SimplyDanny SimplyDanny deleted the fix-bazel-tests branch June 25, 2024 05:28
@keith
Copy link
Member

keith commented Jun 26, 2024

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants