Skip to content

Add RecoveryTest 28 #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

KarolinaGroszewska
Copy link
Contributor

Looked through the list on this issue #1373 and completed RecoveryTest28.

Let me know if there's anything I'm missing! Happy to take on some of the remaining tests as well if this one looks good :)

@KarolinaGroszewska KarolinaGroszewska marked this pull request as draft October 18, 2023 13:48
Suggested changes + fixes from swift run

Handle generic parameter on enum case

Breaking things is fun

Revert "Breaking things is fun"

This reverts commit f5f14f2.

Revert "Revert "Breaking things is fun""

This reverts commit 4bf67d4.

Revert "Suggested changes + fixes from swift run"

This reverts commit 21e8498.

Revert "Add in documentation for AttributeNodes"

This reverts commit 80e91bd.

complete testRecovery28

complete testRecovery28

aaaaaaa
@KarolinaGroszewska KarolinaGroszewska marked this pull request as ready for review October 18, 2023 14:00
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your PR also contains the changes from #2286. Could you rebase it onto main?

@ahoppen
Copy link
Member

ahoppen commented Mar 22, 2024

I just looked at the changes again and it seems like this does not actually fix testRecovery28.

@ahoppen ahoppen closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants