fix: Use DEFAULT_EXECUTE_TIMEOUT for swift package actions #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These timeouts were hardcoded instead of using the argument value, which prevented the argument from having an effect.
|
@swift-ci please test |
|
Gentle ping for review - @shahmishal @justice-adams-apple |
justice-adams-apple
approved these changes
May 13, 2025
|
LGTM, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes a bug where adjusting timeouts using the
--default-timeoutargument doesn't work for swift package actions. These timeouts were hardcoded instead of using the argument value, which prevented the argument from having an effect.I found a few other instances of hard-coded timeouts in
project_precommit_checkandreproduce.py, and wanted to make those consistent even though those scripts do not have a timeout argument.Acceptance Criteria
N/A. Bug fix, no new projects are introduced.