Skip to content

Fix UPASS error for package-distributed-system on linux-debug configuration #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

meg-gupta
Copy link
Contributor

No description provided.

@meg-gupta
Copy link
Contributor Author

@swift-ci test source compatibility

@justice-adams-apple
Copy link
Collaborator

@swift-ci test

@xedin
Copy link
Contributor

xedin commented May 6, 2025

Is it UPASS'ing in all configurations now? We had to XFAIL it before because it was failing in one of the Linux configurations.

@meg-gupta
Copy link
Contributor Author

meg-gupta commented May 6, 2025

@xedin It is unexpectedly passing on Ubuntu now which was the only configuration where it was xfailed'ed

@xedin
Copy link
Contributor

xedin commented May 6, 2025

@meg-gupta it was passing in one configuration but failing in another - rdar://149595882

@meg-gupta
Copy link
Contributor Author

meg-gupta commented May 6, 2025

Aha. Looks like only the ubuntu-debug configurations started upass'ing

@meg-gupta meg-gupta changed the title Fix UPASS error for package-distributed-system Fix UPASS error for package-distributed-system on ubuntu-debug configuration May 6, 2025
@meg-gupta meg-gupta changed the title Fix UPASS error for package-distributed-system on ubuntu-debug configuration Fix UPASS error for package-distributed-system on linux-debug configuration May 6, 2025
@meg-gupta
Copy link
Contributor Author

@swift-ci test

@meg-gupta meg-gupta enabled auto-merge May 6, 2025 23:39
@meg-gupta meg-gupta merged commit 180a35e into main May 7, 2025
1 check passed
@meg-gupta meg-gupta deleted the fixupass branch May 7, 2025 04:44
@xedin
Copy link
Contributor

xedin commented May 7, 2025

@meg-gupta other Linux configuration is going to start failing now.

@meg-gupta
Copy link
Contributor Author

meg-gupta commented May 7, 2025

@xedin which other Linux configuration ? I xfailed the Linux release configuration only in my updated diff.

@xedin
Copy link
Contributor

xedin commented May 7, 2025

Please take a discussion in the radar I mentioned in my previous comment.

@meg-gupta
Copy link
Contributor Author

cc @natecook1000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants