Skip to content

[SR-12587] Use OrderedDictionary for PIF.BuildSettings's internal data structures #4564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aciidgh opened this issue Apr 15, 2020 · 1 comment · Fixed by #8032
Closed

[SR-12587] Use OrderedDictionary for PIF.BuildSettings's internal data structures #4564

aciidgh opened this issue Apr 15, 2020 · 1 comment · Fixed by #8032
Labels
bug

Comments

@aciidgh
Copy link
Contributor

aciidgh commented Apr 15, 2020

Previous ID SR-12587
Radar rdar://problem/62202353
Original Reporter @aciidb0mb3r
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug
Assignee None
Priority Medium

md5: 7cf63cf29bd333a7bc0f09de8c3e094c

Issue Description:

We should use OrderedDictionary instead of regular dictionary for PIF.BuildSettings's internal data structures in order to get deterministic serialization.
@beccadax
Copy link
Contributor

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from swiftlang/swift May 4, 2022
shawnhyam added a commit to shawnhyam/swift-package-manager that referenced this issue Oct 10, 2024
@shawnhyam
Switch to OrderedDictionary for the PIF.BuildSettings internal
a3408c2 
properties, so we get consistent behavior with Codable. Fixes swiftlang#4564.
@MaxDesiatov MaxDesiatov mentioned this issue Oct 10, 2024
Merged
MaxDesiatov pushed a commit that referenced this issue Oct 11, 2024
@shawnhyam
Use OrderedDictionary for PIF.BuildSettings internal properties (#…
96eeb1d 
…8032)

Resolves #4564.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use OrderedDictionary for PIF.BuildSettings internal properties shawnhyam/swift-package-manager
3 participants
@tomerd @beccadax @aciidgh