Skip to content

Fix error in displaySize #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Conversation

mkbrwr
Copy link
Contributor

@mkbrwr mkbrwr commented Dec 13, 2024

HAL.swift and Board.swift had different names for display width and display height.
This change renames vars in Board.swift to have the same names as in HAL.swift

@rauhul
Copy link
Member

rauhul commented Dec 14, 2024

@kubamracek can you take this one?

@kubamracek
Copy link
Collaborator

Yup. I can confirm that the build failure is currently present, and that it gets resolved with this PR.

@kubamracek
Copy link
Collaborator

...and as this example is using Mach-O files, we can't exercise the build in CI currently.

@rauhul rauhul merged commit b1e6289 into swiftlang:main Dec 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants