Skip to content

Temporarily disable unused-but-set-variable until it's fixed in Clang #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

bnbarham
Copy link
Contributor

_dispatch_preemption_yield(++spins) expands to (void)++spins; on
various platforms. A recent Clang change updated the
unused-but-set-variable warning to skip counting operators as a use,
but it ignores (void). Disable the error until that's fixed.

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct, but please make sure that the buildbot is happy with it.

@bnbarham
Copy link
Contributor Author

Started a linux toolchain build: swiftlang/swift#59062

@bnbarham bnbarham force-pushed the temp-disable-error branch 2 times, most recently from 1ac148b to e033277 Compare May 28, 2022 02:13
`_dispatch_preemption_yield(++spins)` expands to `(void)++spins;` on
various platforms. A recent Clang change updated the
`unused-but-set-variable` warning to skip counting operators as a use,
but it ignores `(void)`. Disable the error until that's fixed.
@bnbarham bnbarham force-pushed the temp-disable-error branch from e033277 to 0c622af Compare May 28, 2022 05:49
@bnbarham
Copy link
Contributor Author

bnbarham commented Jun 1, 2022

@swift-ci please test

@bnbarham bnbarham merged commit 1ffe399 into swiftlang:main Jun 1, 2022
@bnbarham bnbarham deleted the temp-disable-error branch June 1, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants