-
Notifications
You must be signed in to change notification settings - Fork 471
Added missing queue macros for building on Android #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing queue macros for building on Android #458
Conversation
This is insufficient, there are additional ones, #453 covers this as well. |
The thing is that (probably unlike Windows) the Android NDK implements some of these macros, but not all of them. I see a couple of alternate ways that I think should work and would probably be better than just sticking them in internal.h like I did here: a) Add missing macros to android_stubs.h. Do any of these approaches sound good or is there another way you’d prefer? |
I'm totally happy with b. It seems much nicer. The file is already annoying to work with, so c isn't very appealing. a would really increase the duplication, so I really think b is the best approach. |
Sounds good! I’ll wait for #453 and re-do this. |
The Android implementation of sys/queue.h is missing definitions for TAILQ_CONCAT() and LIST_FOREACH_SAFE().
Thanks! :) I’ve updated the patch as discussed. |
@swift-ci please test |
CC: @ktopley-apple |
Added missing queue macros for building on Android Signed-off-by: Kim Topley <[email protected]>
TAILQ_CONCAT() and LIST_FOREACH_SAFE() are not defined in queue.h in the Android NDK.
I simply added the macros to internal.h, but please let me know if you’d prefer another place to add them.