tests: support the timer source tests on Windows #454
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
|
@swift-ci please test |
PR #453 provides an initial implementation for timer support on Windows. Support building and running the `DISPATCH_SOURCE_TYPE_TIMER` tests so we can easily verify that timers work correctly. These tests should pass on Windows with this and #453 applied: - dispatch_drift - dispatch_suspend_timer - dispatch_timer - dispatch_timer_bit31 - dispatch_timer_bit63 - dispatch_timer_set_time - dispatch_timer_short - dispatch_timer_timeout
|
@swift-ci please test |
Merged
|
Closing because this is included in #453. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #453 provides an initial implementation for timer support on Windows. Support
building and running the
DISPATCH_SOURCE_TYPE_TIMERtests so we can easilyverify that timers work correctly.
These tests should pass on Windows with this and #453 applied: