Revert "Use numericCast() to get the correct type when creating a dis… #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
CC: @ktopley-apple |
ktopley-apple
suggested changes
Feb 13, 2019
compnerd
force-pushed
the
sometimes-code-is-ugly
branch
from
1de7509 to
102c1c7
Compare
|
Oh, I see; okay, changed to a partial revert. Thanks! |
|
@swift-ci please test |
…patch_block_flags_t." This (partially) reverts commit b048490. Unfortunately, the numeric cast'ed value cannot be used to construct the dispatch_flags_t type. Trying to change to an explicit construction also fails. This repairs the Windows build for the time being. Use the `numericCast` for other targets.
compnerd
force-pushed
the
sometimes-code-is-ugly
branch
from
102c1c7 to
a9e4d44
Compare
|
@swift-ci please test |
|
@ktopley-apple - okay to merge? |
ktopley-apple
approved these changes
Feb 13, 2019
|
Yes, done. Thanks for fixing this up 👍 |
|
My pleasure! |
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
Revert "Use numericCast() to get the correct type when creating a dis… Signed-off-by: Kim Topley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…patch_block_flags_t."
This reverts commit b048490.
Unfortunately, the numeric cast'ed value cannot be used to construct the
dispatch_flags_t type. Trying to change to an explicit construction
also fails. This repairs the Windows build for the time being.