Use numericCast() to get the correct type when creating a dispatch_bl…

[ktopley-apple]

…ock_flags_t.

rdar://problem/44957560

[ktopley-apple]

@swift-ci please test

[ktopley-apple]

@swift-ci please test

[gottesmm]

@ktopley-apple swift-ci is down now. Check ci.swift.org.

[jrose-apple]

*sigh* Sure, I guess.

[ktopley-apple]

@ktopley-apple swift-ci is down now. Check ci.swift.org.

Thanks. I was wondering what the delay was.

[ktopley-apple]

sigh Sure, I guess.

I wish there were a better way. So far, we haven't been able to find one.

[ktopley-apple]

@swift-ci please test

[shahmishal]

@ktopley-apple sorry CI is offline right now.

[ktopley-apple]

@ktopley-apple sorry CI is offline right now.

@ktopley-apple sorry CI is offline right now.

It went down again? Any ETA for return?

[shahmishal]

@swift-ci please test

[compnerd]

Oh, thanks for cleaning this up! I learnt about numericCast afterwards. This is much nicer :-)

[shahmishal]

It's back online

[compnerd]

Hmm, actually, this is interesting, I am seeing a failure with this change:
https://dev.azure.com/compnerd/windows-swift/_build/results?buildId=303

swift-corelibs-libdispatch/src/swift/Block.swift:43:39: error: global function 'numericCast' requires that 'dispatch_block_flags_t' conform to 'BinaryInteger'
                let flags: dispatch_block_flags_t = numericCast(flags.rawValue)
                                                     ^

[compnerd]

I really don't understand how this is broken. flags (aka dispatch_flags_t) is a fixed sized enumeration. The rawValue is going to be UInt32 on Windows, which should conform to BinaryInteger ...

[ktopley-apple]

I agree, and it builds successfully in the Swift CI.

…

On Feb 12, 2019, at 8:12 AM, Saleem Abdulrasool ***@***.***> wrote: I really don't understand how this is broken. flags (aka dispatch_flags_t) is a fixed sized enumeration. The rawValue is going to be UInt32 on Windows, which should conform to BinaryInteger ... — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#444 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AYFzK8CCc4LHM-FiFKItMEi_ljYRmu3dks5vMugLgaJpZM4axn7n>.

[compnerd]

Unfortunately, Swift CI doesn't build for Windows just yet. I've been working on the Foundation bring up for Windows recently, so I am definitely starting to exercise the paths that were not being fully exercised previously.

[compnerd]

I think I get why this fails on Windows, #445 should fix that