Fix redundant access-level modifiers. #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
ktopley-apple
approved these changes
Aug 24, 2018
|
@ktopley-apple Hi Kim, thank you for your review, as well as your supports in #391 ! Would you help fire a test and merge this one if everything goes well, please? |
|
@swift-ci Please test Linux |
|
Thank you for the test, Kim! Looks like it's all good. Would you help merge this PR, please? Many thanks! |
|
Merged. |
|
Thank you, Kim! |
ktopley-apple
added a commit
that referenced
this pull request
Dec 6, 2018
Fix redundant access-level modifiers. Signed-off-by: Kim Topley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aims to make corelibs-libdispatch adapted to this PR, which produces warnings for redundant access-level modifiers.
Following INSTALL.md, I have troubles building libdispatch. It seems the instructions are not up-to-date. It suggests building with
autoconfwhile insteadcmakeshould be used at the moment...@mwwa Hi Matt, would you help review this, please?