Skip to content

Change the signature for DispatchData.enumerateBytes() to match that … #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Change the signature for DispatchData.enumerateBytes() to match that … #385

merged 1 commit into from
Jul 18, 2018

Conversation

ktopley-apple
Copy link
Contributor

…of Data.enumerateBytes() for Swift 4.2 and obsolete the old version.

rdar://problem/40775762

…of Data.enumerateBytes() for Swift 4.2 and obsolete the old version.

rdar://problem/40775762
@ktopley-apple ktopley-apple requested review from das and mwwa July 16, 2018 20:27
@parkera
Copy link
Contributor

parkera commented Jul 16, 2018

I'm not sure you really want to emulate this particular method; we need to get rid of it in favor of using the UnsafeRaw family.

@ktopley-apple
Copy link
Contributor Author

we need to get rid of it in favor of using the UnsafeRaw family.
I agree that we should do something better. This is a short term fix.

@parkera
Copy link
Contributor

parkera commented Jul 16, 2018

Ok

@ktopley-apple
Copy link
Contributor Author

@swift-ci please test

@ktopley-apple ktopley-apple merged commit 9c48a80 into swiftlang:master Jul 18, 2018
ktopley-apple added a commit that referenced this pull request Dec 6, 2018
Change the signature for DispatchData.enumerateBytes() to match that …

Signed-off-by: Kim Topley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants